Ignasi Marimon-Clos

Results 261 comments of Ignasi Marimon-Clos

Would be great but I'd rather not commit yet.

> With the wider adoption of `CoordinatedShutdown` as lifecycle handler for play and lagom, the lagom-specific setting `exit-jvm-when-system-terminated` may become obsolete and replaced with: > > ``` > akka.coordinated-shutdown {...

Note, the gitter thread suggests bumping the version fo the cassandra driver to `3.8` but there's newer version on the `3.x` family. @ds-steven-matison what is the reasoning behind moving to...

Hi @ds-steven-matison, `master` is not the source for Lagom 1.6.x releases, if you build a local release from `master` you'd be building a preview of Lagom `1.7.x`. Instead, I recommend...

See also https://gitter.im/lagom/lagom?at=5f71fad45a56b467a5f63b2e cc @ds-steven-matison

> It won't work though if you're using Kafka. That's an interesting scenario. @TimPigden have you tried using [Broker Testing tools](https://www.lagomframework.com/documentation/1.3.x/scala/MessageBrokerTesting.html) provided in Lagom to expand your mocks? I am...

Hi @lapidus79, at first I thought the issue was related to this [line](https://github.com/playframework/playframework/blame/2d81591b7618202b6ab447e65cb549fa81f7e9bc/core/play-java/src/main/scala/play/core/ObjectMapperModule.scala#L44) and https://github.com/akka/akka/pull/29797. But even as I tuned the `Visibility` of the `ObjectMapper` to be as open and...

~@lapidus79 I've created a [unit test](https://github.com/playframework/playframework/pull/10840/files#diff-9f335c195de5f739f362940ab51589356c500af487ec1601ec7142e62456f3b3R162-R185) in the Play codebase testing the custom `JsonNodeDeserializer` but it is not failing.~ ~I think the problem is a combination of `JsonNodeDeserializer` with other...

@lapidus79 I put together a fix but while it's not released there's also a workaround you could use in your code. In ` ChildDeserializer`, instead of: ``` JsonNode node =...