Quentin Renard

Results 96 comments of Quentin Renard

If you check the artefact at the bottom of https://github.com/area17/twill/actions/runs/9214252760, you'll see this error: ![failure-A17_Twill_Tests_Browser_BlockEditorMediaTest_testMediaCropsForNewBlocks-0.png](https://github.com/area17/twill/assets/708498/a91fe2d3-fd54-434d-aabf-17a9efb3a235)

> This PR would take care of https://github.com/orgs/area17/projects/3/views/6?pane=issue&itemId=12754007 That roadmap item isn't about disabling blocks programmatically, but that's a good addition, still! Disabled blocks in the roadmap are about a...

I agree with updating the default. You can use this until this is released: https://github.com/area17/twill/pull/2299

Support for medias fields in JSON repeater has been released in Twill 3.3.0: https://github.com/area17/twill/pull/2554 You will need to upgrade if you want to use this.

I see that you are using `translatable()` on the medias field. Does it work if you don't?

I can check if that would cause any unexpected issues, but in the meantime I'd suggest you use curly quotes `’`, which is more “correct”: https://practicaltypography.com/straight-and-curly-quotes.html.

Yes, this is exactly the direction we'd like to pursue for Twill 4+. No more strings and arrays of strings all over the place. With Twill 3 we made great...

Ugh, this sounds really bad, we'll be looking into it asap. Does this [PR](https://github.com/area17/twill/pull/2688) help by any chance? I have not reviewed it yet.

Thanks @Tofandel, can you make sure to test the 3 following things: - changes in a browser in a block render in the Editor previews and full preview - changes...