Quentin Renard

Results 96 comments of Quentin Renard

Let me clarify this. We can agree this is not pretty, but it is temporary to avoid a breaking change. In https://github.com/area17/twill/pull/2525 I asked @zeezo887 to add a new option...

Something isn't clear for me in your report @antonioribeiro. The yellow error pages are from Twill and that's what we want when there is an error inside Twill, not the...

I did review this and actually made a fix for it here https://github.com/area17/twill/commit/042c87e190760e140a746d0ee005c99408078c3c. Could you check what I may have overlooked?

Hi @Tofandel, thank you so much for working on this! The only thing I'm wondering about is whether or not this change may have a breaking impact on existing revisions.

This is great @Tofandel thank you. The custom exception handler has definitely been a source of issues and this approach is so much better.

I'm open to do this, thanks for suggesting it. I will ping you when it is ready to rebase.

🤔 it's definitely supposed to be there, see https://github.com/area17/twill/blob/ce0fbf153cb455514eeea2b800ab46d569e38c0a/views/users/create.blade.php#L14-L25

The all option is definitely a regression and should not end up there, that's for sure. The fact that you're logged in as administrator seems strange to me, you're supposed...

Of course not, I wasn't suggesting you need to use superadmin users, I wanted to understand why you were logged in as an administrator. Now I understand the non-sensible default...

Great stuff, thank you! I'm not sure I'm following your point about the ability to sort blocks. The order specified in the array of available blocks passed to the block...