iequidoo
iequidoo
So this can be merged as 1.142.x is released from the `stable` branch anyway. But going to wait a bit for more reviews
W/o the seccond commit (0f6f3f1aa6d792849088de6fe98623b86258e041) `tests/test_securejoin.py::test_qr_readreceipt` fails: https://github.com/deltachat/deltachat-core-rust/actions/runs/10517506038/job/29141924140 ``` DEBUG root:rpc.py:180 account_id=3 got an event {'kind': 'Info', 'msg': 'src/imap.rs:1119: Marked messages 6 in folder INBOX as seen.'} DEBUG root:rpc.py:180 account_id=3...
From https://www.rfc-editor.org/rfc/rfc3501#section-6.3.11: > If the mailbox is currently selected, the normal new message actions SHOULD occur. Specifically, the server SHOULD notify the client immediately via an untagged EXISTS response. If...
I made a dumb merge, but this actually breaks what was fixed in 418dfbf9946027567d598fa94e528c0ec44e34be because groups are promoted by SMTP, but QR code tokens are synced by IMAP. Need to...
> What is the reason to introduce "IMAP APPEND" at all? We typically try to use IMAP only in a minimal way. I forgot to add the motivation to the...
> the message will be displayed as unprotected anyway What do you mean by this if presence of a padlock shouldn't be affected by the message content anyway?
I'd also suggest that if a text/plain part only containing an inline PGP message is inside another signed part in turn (e.g. inside encrypted+signed message, though i have no idea...
> If the whole message is encrypted+signed with PGP/MIME, then it should have a padlock. The message has valid signatures, it is signed as a whole. It's signed as a...
Then i suggest instead of `----BEGIN PGP MESSAGE-----` prepend the message with a warning like "The sender may not be the author of this decrypted message and may not know...
> An attacker can also achieve the same by simply relaying a PGP/MIME message that does not have protected `From:`, it will be displayed without any warning at all, just...