iequidoo

> `days_until_first_donation_request`, `days_until_next_donation_request` and `LastDonationRequestTimestamp` (instead of _period_check, period_msg, DonationRequestTs_)? Renamed to `secs_between_checks` (it's only a consequence that the first request appears after this time), `secs_between_requests`, `DonationRequestNextCheck` (we don't always...

> * for now, we do not want the message to re-appear every some time, we can add that at some point, but initially it is not wanted - the...

After re-reading the code, i think that the intention was initially to avoid creating chats for DC reactions, so i changed it in this direction. A little more code, but...

> as it is about is_reaction in classic path - maybe just set the condition there. that would also make the logic change easier to understand and to judge if...

IMU of https://www.rfc-editor.org/rfc/rfc9078.html, there may be other message parts, not containing `Content-Disposition: reaction`, but smth else useful. DC never creates such messages, and if they never exist in practice, we...

> Why does this happen? If we download messages in order, then message is usually newer than all messages received so far. This may happen if Sentbox is fetched after...

> Not sure about adding `MessageState::Out` though, it's not clear how to handle MDNs for them. `MessageState::OutMdnRcvd` isn't really used in the code, so it can be safely removed. Its...

> So this is a fix for Gmail? On most providers outgoing messages from Delta Chat never appears in the Sent folder, they are BCC-ed to self and arrive into...

> But if a received outgoing message is older than some non fresh message, better sort the received > message purely by timestamp. Actually this is an heuristic in this...

Didn't expect that, but this is incompatible with 796b0d77525a18ddf34deb6f7b9cc9c975b448b2, need to debug. EDIT: Can't reproduce the `test_verified_group_vs_delete_server_after` failure on my machine... EDIT: This PR isn't the reason, the test also...