Islam El-Ashi
Islam El-Ashi
@THLO WDYT? I believe this request has been re-occurring, and while developers can get this information from a call to `get_utxos`, it's arguably not intuitive.
The (not very good reason) this inconsistency exists is because these structures were written by different authors. The current thinking is to update them to all not return a `Result`,...
Good to know, thanks. Perhaps a cleaner way would be to allow specifying the directory within the repo in the mops.toml file?
Should this issue be closed then? I also confirm that it works in dfinity/llm
> @ielashi do you aim to make changes related to the comments? (icp ninja link, info that a canister on icp ninja might be recycled and could already hold some...
Thanks @dragoljub-duric. I left some comments. Additionally, the PR description I think can be improved, where we concisely write the problem and the solution. It's currently more of a checklist...
> @ielashi @dragoljub-duric Hey guys, this has been open for quite a while. Should we try to wrap it up? I'm now nearly done with the BTreeMap changes. I'll schedule...
> Do we want to include this change in the upcoming 0.6.0 release? No, ideally this would follow in a minor release, so that we have had time to test...
> @ielashi I saw that we have a new release. Can you please approve it now? Hey @dragoljub-duric, I'd like to do some more testing given that we found a...
> @ielashi Can you please take another look? @dragoljub-duric Thanks! From a code standpoint this looks good. The remaining concern I have is related to performance. Prior to this PR,...