Islam El-Ashi

Results 44 comments of Islam El-Ashi

> > I assume that we're fine with the current status of this PR > > How about the call_on_cleanup analogy that I raised in the unresolved comment above? @mraszyk...

> @ielashi I replied > > > The reason for that is that call_on_cleanup, unlike this hook, cannot make outbound calls. > > As long as it can schedule a...

High-level questions: 1. Discovery: how will developers know that this page exists? 2. Maintainability: how do we plan on keeping this page up to date? I can already see that...

> Some of the errors are implementation specific which means that we probably don't want to include them in the spec. And as Adam also mentioned explaining some of them...

> Is it really correct that the goal is they should be able to run on the same subnet? In that case we'd need to to specify the exact cycle...

@nzoghb It would be great it you could update the README with these instructions :)

Hi @LefterisJP, thanks a lot for the feedback. We'll be looking into incorporating these suggestions - no timelines to be communicated yet unfortunately, but we'll keep it in mind as...

> Would be nice to implement this for (A, B, C...) in accordance with candid. I agree. We don't rely on candid for the (A, B) encoding though and neither...

Hey @bitdivine, a deque would certainly be a nice addition. I can see it being implemented either on top of `BTreeMap` or on top of our `Vec`/`BaseVec` implementations. Can you...

Thanks for the context @bitdivine. As discussed, we have a few options: ### Build a deque based on stable `Vec`. * (+) Performance: `push` and `pop` would be O(1). *...