Ian Douglas Scott

Results 545 comments of Ian Douglas Scott

I'm not sure we can get quite that style with [`GtkScale`](https://developer.gnome.org/gtk3/stable/GtkScale.html). It does support adding marks at certain values with text, but it doesn't look quite the same. And strangely...

The scale could be labelled with the percentages easily enough. I suppose brackets could be added by adding a `GtkDrawingArea` below the `GtkScale` and rendering them with cairo. It may...

[Discussion with upstream](https://gitlab.freedesktop.org/upower/upower/-/merge_requests/49) seems to favor profiles, ideally vendor-provided, and probably no ability to set arbitrary thresholds in the UI. Though we can do something different. I like the way...

I have this partly working, using the DBus API in https://github.com/pop-os/system76-power/pull/197. Selecting a different option pops up an authentication dialog: ![Screenshot from 2020-11-12 07-04-32](https://user-images.githubusercontent.com/2263150/98957127-b2a88080-24b5-11eb-985b-d040041e5fd7.png) ![Screenshot from 2020-11-12 07-04-20](https://user-images.githubusercontent.com/2263150/98957139-b63c0780-24b5-11eb-9a1d-3699be907168.png)

This is functional, looking like the previous screenshots, plus this inline in the panel: ![Screenshot from 2020-11-16 09-18-34](https://user-images.githubusercontent.com/2263150/99285683-ba855f00-27ec-11eb-8012-246982182808.png) There some things to sort out before this can be released. Supposing...

> The thresholds and copy need updating to the below options. That should work. Then I suppose we update the EC so it defaults to the values listed here for...

Updated: ![Screenshot from 2021-01-19 10-52-11](https://user-images.githubusercontent.com/2263150/105079581-7872d680-5a44-11eb-8c2c-f684657399fc.png)

Great idea, and fairly easy to do. I was just thinking it could be clearer that the row is clickable and what it does: ![Screenshot from 2021-01-19 12-01-07](https://user-images.githubusercontent.com/2263150/105086606-15863d00-5a4e-11eb-8bfe-d5fa3703d8f1.png)

It could show something like `Custom (60%-70%)`. It's inevitably kind of weird determining how the UI should deal with values it doesn't allow setting. But hopefully that's not too much...

Updated, as suggested. When the profile is "custom", opening the dialog results in no radio button being selected, and choosing one changes the values as usual (it already worked that...