Ian Douglas Scott

Ah, I see. So https://github.com/Smithay/smithay/pull/1516 changes `known_kbds` and the like to use `wayland_server::Weak`, while the change here uses a `std::sync::Weak` in `KeyboardUserData` and `SeatUserData`. Either prevents a leak, and both...

I guess `EGLContext::wait()` should also require a current context. Edit: For modularity the `egl` module could define an `ActiveContext` trait, and require that for `create`/`wait` instead of the requirement being...

```rust self.primary_plane_damage_bag .add([output_geometry.to_logical(1).to_buffer( 1, Transform::Normal, &output_geometry.size.to_logical(1), )]); ``` A transform could be applied here, but I don't know if `RenderOutputResult.damage` should already be transformed. It does seem a bit odd...

Updated with a couple fixes so the CI build with different anvil features passes.

This definitely would be nice to have. We'd need to decide how to handle multiple brightness devices. - The applet presumably should have sliders for each output, but key bindings...

I see `ddcutil` is also quite slow to get or set brightness or other settings. Apparently this is expected: https://www.ddcutil.com/faq > ddcutil spends 90% of its elapsed time in waits...

So it can be faster if some persistent service keeps open a DDC connection? That may be doable.

Added some testing improvements. I see some issues trying to test `statics:` and `varargs:` (https://github.com/elinorbgr/dlib/issues/23, https://github.com/elinorbgr/dlib/issues/24), but I think the changes here are good, and aren't causing issues that don't...

Yes. Simply adding `#[cfg(feature = "libwayland_1_22")]` appears to work as expected in wayland-sys if it uses this version of `dlib`.

Good point. Currently on cosmic-comp the screenshot UI and polkit prompt are just layer shell surfaces, but it would be good for them to be privileged clients that are given...