IDG SERPRO

Results 109 comments of IDG SERPRO

> Yes but one can easily change this. I agree. Actually, that's what it's being done. But it's not ideal. The idea of using specific templates is exactly to avoid...

> please check if the failing tests are releated to the name of your add-on. The `isort` yes. But changing the name to `collective.newaddon` gives: ``` src/collective/newaddon/locales/update.py:44:11: P202 format call...

> Travis is already configured to run the code-analysis part already provided by buildout I was thinking about `flake8` running against a generated addon. It would catch the errors above....

Just by running a `content_type` template with all default options gives errors as well: ``` src/collective/myaddon/tests/test_ct_todo_task.py:43:9: F841 local variable 'obj' is assigned to but never used src/collective/myaddon/tests/test_ct_todo_task.py:46:5: E303 too many...

> PR's are very welcome We know... Unfortunately, bobtemplates.plone is on plone namespace and we can't sign the contributor's agreement because of some internal legal reasons. We know how hard...

I vote for the 2 solution. Just assume `browser:resourceDirectory` if Plone is 4 and `plone:static` otherwise.

Also, you add a behavior named `plone.versionable`: https://github.com/plone/bobtemplates.plone/blob/8d1ca04c099cc4ac1c67e98f3b82a728aa96262a/bobtemplates/plone/content_type/profiles/default/types/%2Bdexterity_type_fti_file_name%2B.xml.bob#L93 But right now, in github search, there's no reference to such behavior. https://github.com/search?l=XML&q=org%3Aplone+versionable&type=Code https://github.com/search?l=XML&q=org%3Acollective+versionable&type=Code Didn't you mean `plone.versioning` behavior from https://github.com/plone/plone.app.versioningbehavior/blob/58a8253077ae3b760d35639618440b1b4dcc0e8f/plone/app/versioningbehavior/configure.zcml#L18?

@pbauer can you check this? I can confirm that using to_path is worse than using to_object.

@pbauer I'm out of time now. But I think that example would be better: https://github.com/plone/plone.app.dexterity/blob/82bba1e369d7a2678f358b7ffa2b9fc873429afc/docs/advanced/references.rst#back-references