Idel Pivnitskiy
Idel Pivnitskiy
Existing `quality` Gradle's task we have checks javadoc only for modules we publish, it does not include javadoc of example. Even though we do not publish the examples JavaDocs we...
On the server-side, if service does not subscribe to the request payload body and fails the response payload body publisher, the connection will eventually be closed, but the `connection.read()` publisher...
`SplittingWriteEventsListener` expects the following sequence of HTTP messages: ``` meta-data → Start → Payload → InProgress → trailers → End ``` If the source does not limit recursion to a...
`BufferInputStream` does not implement mark/reset methods of the `InputStream`, while we can. We should implement it to make it close to `ByteArrayInputStream` and `ByteBufInputStream` (from netty) behavior.
`thenCancel()` is on the `*LastStep` interface, but it triggers cancellation right away ignoring all previous steps. Example: ```java @Test public void requesterPayloadBodyDoesNotTimeoutWhenIgnored() { Duration timeout = ofMillis(100L); TestPublisher payloadBody =...
We had a few cases when we used `Single.defer` operator in filters but did not apply `Single.subscribeShareContext()` operator. For example, see #1302 and #1308. Ideally we should improve our test...
Jersey inconsistently returns 200 or 204 when an endpoint returns `CompletionStage`. The status code depends on the state of `CompletionStage`. If it is already compete before JAX-RS method returns, then...
`ConnectioFactoryFilter`(s) may already create a new connection but work with it before emitting downstream. See [ProxyConnectConnectionFactoryFilter](https://github.com/apple/servicetalk/blob/master/servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/ProxyConnectConnectionFactoryFilter.java) as an example. When cancel is received after a new connection is created we...
We allow users to set `SocketOption`s on the client/server builder and to query `SocketOption`s on `ConnectionContext` API. Currently, these methods support only `SocketOption` constants from `java.net.StandardSocketOptions` and `io.servicetalk.transport.api.ServiceTalkSocketOptions`. However, the...
We have a modified implementation of `HttpExecutionStrategies.difference` function in `http-router-jersey`: https://github.com/apple/servicetalk/blob/464554ad984bc4897e7ba72e54a2ac0f12a9ecd9/servicetalk-http-router-jersey/src/main/java/io/servicetalk/http/router/jersey/EndpointEnhancingRequestFilter.java#L487-L508 We introduced it #682 to improve accuracy according to jersey router specifics. However, we should reconsider this approach and...