Ioana Cristescu

Results 19 comments of Ioana Cristescu

I faced a similar issue, where the token used by `dune-release` was no longer available. I used the env variable `DUNE_RELEASE_GITHUB_TOKEN` to point `dune-release` to a new token. Indeed it...

Another nice usage of `Memtrace` is to use it in scripts to filter allocations based on which functions made them: maybe plot allocations from `index` vs the overall allocations? (there...

@Ngoguey42 @irmaTS I added a commit with some suggestions, so that we can unblock this PR (and resolved all conversations, but please reopen them if you don't agree).

Something else we should be careful at, is that I think the max memory usage reported by all our benchmarks are for the main process. I started a bench which...

The `finalise_gc` is taking up to 3s, leading to commits of `3s` as well. There are 4 major steps in `finalise_gc`, I plotted the time each takes (I run the...

Having read up a bit on optics I now understand better your proposal, I also think it's great ! I'm not sure I understand the section on the monad parametrised...

@zshipko ah yes, good find! We need to clear the lru after the gc ended to removed the _gced objects_ from the lru - the objects kept indeed have the...

The issue is that doing mem/find on a gced object it should return false/not found. The assumption that users never need to lookup a gced object, I'm not sure that...

could you add some mli files with some documentation to help us review it? thanks!

no, its a refactoring possible on top of #1795. It's not possible that `t.info.ptr` is a key but not `t.v` , so a (small?) simplification is possible in the export...