Iskren Ivov Chernev comments

Results 130 comments of


                                            Iskren Ivov Chernev

Dramatic increase in package size

oh, snap, npm publish is dumb, I'll release 0.5.37...

Dramatic increase in package size

0.5.37 released

Dramatic increase in package size

I use Linux, if the issue is really related to that, we could release a few different versions with different year spans. I mean we have bundles (with code) for...

Dramatic increase in package size

I just checked -- on a MacOS zdump is 32bit, so it ends around 2047, and on Linux it can go up to 2437. I think the "correct" one is...

.tz(.., true) incorrect around DST

Yep, I can verify that the bug exists. We could try to extract pieces (year, month, day, hour, minute, second) and re-create a new moment from that, it should work...

.tz(.., true) incorrect around DST

Possibly related to #935

guess returns obsolete timezones (likely due to Intl)

@trevorgehman well, there are 2 parts in this, if guess indeed uses `Intl` in your case, then it is "not our problem". Maybe it could make sense to add an...

Uncaught Error: Cannot find module './locale'

I'm a bit confused here, what exactly is the issue with moment and how should we fix it? Would `peerDependency` work?

`guess()` breaking change with node 10

Is this still an issue?

defaulting to current date-time uses UTC (ignores timezone)

Yep, I can reproduce this issue on latest moment + moment-timezone. Some mechanism to request "current local time" from moment to moment-timezone might be required.