Ryan C. Gordon
Ryan C. Gordon
e51760e11166a81dd4ba504df559b9b16100815c fixes one of the two remaining ThreadSanitizer issues. This code changed for SDL3, so we don't need to cherry-pick it.
c331b64d796d2abf2fd03ec72f733642483d3623 resolves the rest of the ThreadSanitizer complaints for PulseAudio on SDL2. SDL3 was already ThreadSanitizer-clean, and none of this code applies there...so we're done!
> Remove the parameter for SDL_PauseAudioDevice() and add SDL_PlayAudioDevice() to reduce confusion about how to start playing audio after opening the device. _Originally posted by @slouken in https://github.com/libsdl-org/SDL/issues/3519#issuecomment-1180670263_ > For...
I've been working on ripping up the audio API for SDL3. This is the current state. I'm not sure how readable a diff is here, but this is still changing...
Ok, so thinking about this more, the problem is that SDL_AudioStream doesn't let you change output formats once you create it, but that's because we convert data as it is...
> (Play/Pause/Stop or lock/unlock on a non binded, would be a no-op) I'm thinking maybe we don't need these at all; unbinding a stream would "pause" it with whatever data...
> Wishlist item: there should be a way to query if device permission is available, or forbidden, or pending user response, if this is something various platforms expose. > >...
I think this is good to go at this point? The audio subsystem has had a massive redesign and looks like it's in pretty good shape, so I'm closing this....
I'm not sure what controllers would be able to turn off programmatically. Surely not many of them...?