Ian Baker

Results 409 comments of Ian Baker

If you've written a custom `DataSource` I recommend testing it with a subclass of [`DataSourceContractTest`](https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/testutil/DataSourceContractTest.html) to check you implemented the interface correctly and fully. More info here: https://medium.com/google-exoplayer/standardising-datasource-implementations-through-testing-b7a8ab04f8d1 From the...

Not sure if you've already seen it, but you might want to take a look at our [`DefaultHttpDataSourceContractTest`](https://github.com/google/ExoPlayer/blob/release-v2/library/datasource/src/androidTest/java/com/google/android/exoplayer2/upstream/DefaultHttpDataSourceContractTest.java) and the [`HttpDataSourceTestEnv`](https://github.com/google/ExoPlayer/blob/release-v2/testutils/src/main/java/com/google/android/exoplayer2/testutil/HttpDataSourceTestEnv.java) it uses to set up serving test data at...

If you add logging, do you see control flow entering the `if` inside `onTaskRemoved` when you close the app? If so, which of the 3 OR'd conditions is true to...

Please can you capture an `adb bugreport` shortly after reproducing the issue (including your additional logging) and either upload it here or send it to [email protected] with the subject `Issue...

This line from the BR makes it look like your service crashed (but I can't see any stack trace or similar before that to indicate what would have caused the...

I played the provided stream in the demo app. I paused it for ~5 mins. Then I resumed playback and pressed the "skip to next" button to seek back to...

That is just a warning (because we don't know what the "right" (playback) thread is yet), but looking at the stack trace it seems the call will be from the...

Thanks for the extra precision @pai-vignesh, that means the issue is almost certainly introduced by http://r.android.com/3163319 as it's the [only commit difference between RC01 and RC02](https://android.googlesource.com/platform/frameworks/support/+log/4237f41666396b1ff39ffba3563807151fed2313..8b6a421412278b50d22e0c16099229b1f2cd7362/tv/tv-material) (and stable is identical...