Ian Baker

Results 409 comments of Ian Baker

Ah, I didn't realise that the `Res` class is [generated and project-specific](https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-images-resources.html#resource-usage), like `R` classes on Android: > After importing a project, a special Res class is generated which provides...

**EDIT**: The suggestion in this comment of creating a separate `ResolvingByteArrayDataSource` is no longer needed after https://github.com/androidx/media/commit/4dd83606931a95bb874ff00407aa8fad02a4328c which allows passing a `UriResolver` to the library's `ByteArrayDataSource`. The rest of the...

https://github.com/androidx/media/commit/4dd83606931a95bb874ff00407aa8fad02a4328c changes the library's `ByteArrayDataSource` to allow passing a `UriResolver` into the constructor that is called during `open()`, so the wrapper class described above is no longer needed (I will...

Thanks for the code suggestions @hichamboushaba - a couple of thoughts if you or others are interested: 1. You can write a contract test for your `JarResourceDataSource` by subclassing [`DataSourceContractTest`](https://developer.android.com/reference/androidx/media3/test/utils/DataSourceContractTest)....

No problem - some other thoughts: One of the problems with building a `DataSource` directly on top of (only) `InputStream` is the lack of 'size' info. You're using [`InputStream.available()`](https://developer.android.com/reference/java/io/InputStream#available()), but...

@suchiz you seem to be **both** calling `Res.getUri` before constructing your `MediaItem` and then also calling `Res.readBytes` with the **result** of this. Based on the example URIs in the top...

@joeldenke See discussion above, where `Res.getUri` returns a `jar:` scheme URI, which is currently not supported by media3.

The provided file is an SRT file. I agree with https://github.com/androidx/media/issues/2167#issuecomment-2736041777, this is a duplicate of https://github.com/google/ExoPlayer/issues/3644. I will close that and use this to track it instead, to move...

> * Is there a planned solution? Plans have not changed since https://github.com/google/ExoPlayer/issues/3644#issuecomment-565503504, in particular this sentence is still true: > It's unlikely we'll find the time to add this...

> 2\. Any video with DVB subtitles Please can you provide a clip that we can use to reproduce this. Please either upload it here or send it to [email protected]...