Isaac Cambron

Results 142 comments of Isaac Cambron

Yeah, we could have an `invalidData` field. I think we'd accept that PR Note that in 2.x, we are planning to not have invalids at all and just throw, since...

Let me make sure I understand your request: you would like a function that takes in a plain ol javascript object, presumably a serialized-and-then-deserialized DateTime instance, and returns a DateTime?

That would require a bit of mucking with the DateTime constructor, which is a little messy. But it's a reasonable request; I'd take a crisp PR that does this

@noorix1 We're just using the built-in Intl support to format Islamic and Islamic Civil calendar dates. If you can show that using the Intl API directly gives you different results,...

I agree that `fromFormat` should support that token one way or another. Note, though, that all your use cases presented there would get parsed fine by `fromISO`. That's most of...

I disagree: if we made it more lenient, it would easy for people to get the keys wrong, because none of them are required. This is especially painful given that...

You needn't ever copy a date time like that; they're immutable, so just use the original where you would use the copy. It's like how you never copy a string...

@mees- this a bit of a complicated one. For starters, the method's implementation has significantly changed since this was reported. This is the current implementation of `hasSame`: ```js hasSame(otherDateTime, unit)...