Isaac Cambron

Results 142 comments of Isaac Cambron

@GillesDebunne I was thinking about that. I don't currently have the bandwidth to take on the formatter separation; things are very busy at work. So unless you want to take...

The asymmetry between the getter and setter makes me want the explicit method more, not less. But why don't we just have both? `Settings.setDefaultLocal(anyOfSeveralDifferentTypes)` and `Settings.defaultLocale = hasToBeAZone`. Then we...

I'm a little confused by the need for a types file. Seems like that would just come for free?

@GillesDebunne I haven't been rebasing 2.0 to prevent this change from getting more complicated than it has to be, so I think the plan will be to merge this, then...

@GillesDebunne Yeah, I merged master in over the weekend. `2.0-take-2` should be all caught up. I am running Node v13 and the 2.0 branch tests pass for me, so I...

Yeah, the formatter is a little dumb about negatives. It's saying "(-1):(-30)" because it doesn't know how to pull the negative out as "-(1:30)"

@chinmaydalvi I think there's some thinking required here, because it's a little under-specified. There are a few issues to sort out: 1. Units can be mixed, with some negative and...

On mixed-sign values: > We really just need to know if the total of the duration is less than 0 - if it is, then a single - can just...

If it's a perf thing, this does it in one go: ```js const zone = "Europe/London" DateTime.fromObject({zone}) ``` Since that's not a very obvious API, I think we can consider...

Just depends on whether the two `local()` calls resolved in the same millisecond or not. If you assign that to a local var and use it both places, does it...