Isaac Bennetch

Results 106 comments of Isaac Bennetch

Unless I'm very mistaken then yes, all Suhosin code can be removed from the master branch. Thanks!

> Bug Definitely, I just picked the wrong template.

I've created this but we can first discuss it at #19909 before merging this.

Thanks for the great feedback. I've incorporated most of your comments in https://github.com/phpmyadmin/phpmyadmin/pull/19881/commits/e8446253aa6d6a5903373df01838be82e2d1070c which I just pushed along with some other work that's in progress.

I think this is ready to go except I think we should decide how to handle the phpmyadmin/setup vs phpmyadmin/public/setup section from https://github.com/phpmyadmin/phpmyadmin/pull/19881#pullrequestreview-3337446202. I believe what I've written here matches...

Thanks for the report. I was just using them earlier today so hopefully it’s a quick fix.