Isaac Bennetch

Results 64 comments of Isaac Bennetch

Thanks Marc for the report. These are the syntax variations we need to accept (copied from the manual page): > CHAR(10) CHARACTER SET utf8 > NATIONAL CHARACTER(10) > NCHAR(10) and...

I confirm this issue (which actually exists in our sql-parser library): ``` ./bin/lint-query --query 'call foo.bar' phpmyadmin/phpmyadmin#1: Unexpected token. (near "bar" at position 9) ```

I agree, moving to sql-parser repository. You may work on it if you'd like. @svaningelgem thank you for the report.

Thank you for reporting. This has been fixed with #203 and will be part of the 4.3.0 release of sql-parser.

I'm going to leave this opened because while the second query works, the first one (`./bin/lint-query --query 'select 1 name'`) still gives an error.

@mostertb Perhaps you have some thought about the first query as well, since you did a great job on the other parts. Not a huge deal if you don't have...

I can reproduce this with our parser library, sql parser, and I've confirmed that it definitely doesn't like the `KEY` keyword. You're correct that the two other errors that follow...

I unfortunately don't know the answer off the top of my head, but we will try to get an answer for you. About the documentation, I agree that it needs...

Note that this does not circumvent existing access controls; it cannot be used to escalate privileges.

Additionally to what William said, the first one has existed for much longer than the second one and now that we have the officially-endorsed repository, we do not want to...