Iñaki Baz Castillo

icon indicating a website link https://inakibaz.me icon indicating an email [email protected]

icon location Passionate about new technologies, Open Source, modern web applications development, Node.js, C++, SIP protocol and, above all, Real-Time Communications.

Results 550 comments of Iñaki Baz Castillo

signed-to-unsigned overflow in send_side_bandwidth_estimation.cc

Anyway changes are applied into current v3 in this PR: https://github.com/versatica/mediasoup/pull/944

SIGSEGV at 'RTC::WebRtcTransport::OnIceServerTupleRemoved'

> Not yet, I just updated from 0.9.3 to 0.10.0 and changed the type ListenIP that causes build errors. I have no idea what you mean here.

SIGSEGV at 'RTC::WebRtcTransport::OnIceServerTupleRemoved'

So you are using Rust, you are not using WebRtcServer at all and you changed something in the Rust code. And it crashes due to something in WebRtcServer (that you...

SIGSEGV at 'RTC::WebRtcTransport::OnIceServerTupleRemoved'

Now I realize that it is RTC::WebRtcTransport::OnIceServerTupleRemoved() the one crashing rather than in WebRtcServer...

SIGSEGV at 'RTC::WebRtcTransport::OnIceServerTupleRemoved'

There is no freed memory usage in there. `this->tuples.erase(it)` just removes a `TransportTuple` pointer from a map, it doesn't free it.

SIGSEGV at 'RTC::WebRtcTransport::OnIceServerTupleRemoved'

GOOD POINT!

SIGSEGV at 'RTC::WebRtcTransport::OnIceServerTupleRemoved'

@ybybwdwd please take a look: https://github.com/versatica/mediasoup/pull/915

Write our own bandwidth estimator

Thanks, we are not doing BBR anyway.

Write our own bandwidth estimator

We'll update when there is progress.

Write our own bandwidth estimator

We just use libwebrtc dep for BWE.