ian woolf

表示关注 我想在log-pilot上做一些功能，让filebeat的能力表达出来，比如多行合并什么的 但是如果filebeat是 改过的，我不知道和官方的有什么区别，会不会有影响

你这个参数，好像要改这里 https://github.com/AliyunContainerService/log-pilot/blob/master/assets/filebeat/config.filebeat#L67 我不知道能不能生成两个output配置，比如不同业务日志打进不同es里，如果可以的话应该也能这个日志名 官方同学看下？我也有类似需求，不同服务日志打给不同es 索引里

> I think there's just one last thing: the `os` import needs to be removed. > > ``` > # github.com/prometheus/prometheus/promql [github.com/prometheus/prometheus/promql.test] > promql/engine_test.go:19:2: imported and not used: "os" >...

> OK, so I think I've figured out why `test_windows` keeps failing with the following error: `testing.go:967: TempDir RemoveAll cleanup: remove C:\Users\circleci\AppData\Local\Temp\TestQueryConcurrency3635900781\001\queries.active: The process cannot access the file because it...

> In `path_test.go` are defined both the new `chdir` function and the old chtmpdir that returns a function to use in a defer statement. > > Probably the old function...

As i wrote in https://golang.org/cl/307651, one depsRules of `go/build` need to be add if add the `internal/testhelper` package. Or move the `chtmpdir` to `testing`. Because of the additional depsRules, it...

@roidelapluie do you think there are any unresolved issues? i need a review, please feel free to review 3ks

> cc @ianwoolf can you please rebase this pull request? Thanks! done :)