ian woolf
ian woolf
> Can we instead change the signature of getMMapedFile to `(filename string, filesize int, logger log.Logger) ([]byte, io.Closer, error)`? looks more reasonable. Code has been updated
> Ok I finally got my hands on a Windows computer to try out #10321... and I can't reproduce the test error. I think it's something to do with CircleCI,...
the `dirver.UI` is same as `internal/plugin.UI`， but `internal/driver.PostProcessor` require `internal/plugin.UI`. In my own go version, just set the type `dirver.UI` as `internal/plugin.UI`, and everything is ok. But I don’t know...
@aalexand thanks for your review. is this pr can be accepted?
First of all, `internal/driver.AddCommand` does not seem to be called. And because it is under the package `internal`, it cannot be called outside the package. For example, in this scenario,...
> This seems convoluted. Can you instead run `pprof` command as a child process redirecting its output to a pipe that your program reads from? it is executalbe. but it...
Is this demand acceptable? It did solve my problem Or is there any better way？
Maybe need to add some other multiline attributes?
may i have a review?