ianwal

The Python bindings I didn't have time to get working fully with Windows. It's a build issue. But, vpdq itself does build and work with Windows. The way the binding...

>FFmpeg need to be installed through MinGW because I installed it from https://www.gyan.dev/ffmpeg/builds/ and added the path manually. Not sure. I don't have a lot of experience with MinGW. If...

Yes, it looks like the dependencies for vpdq are not installed. They are listed in [vpdq README.md](https://github.com/facebook/ThreatExchange/blob/main/vpdq/README.md#install-libav). For now, we can just add the dependencies where FFmpeg is installed in...

This should be tagged for PDQ Python, not vpdq. This PDQ Pure Python implementation doesn't have a connection to vpdq 🙂

Please copy any modified pdq files to `vpdq/cpp/pdq/cpp` as well (this sucks...)

> Done, I copied the core files there that should have 100% the same behavior but I am not familiar with vpdq so not sure how to wire it up....

Do you need to approve workflow run @Dcallies? Let's double check for any new compiler warnings that show up there before merging.

I'm also segfaulting while running on patches.toml on Zelda64Recomp after #150. Reverting to 6860826da32d0565f67ee8e31bdb05e41795cf56 fixes the issue. ### Build env info Crash log while building Zelda64Recomp: ``` [893/1038] Generating /home/ubuntu/repos/Zelda64Reco...ubuntu/repos/Zelda64Recomp/RecompiledPatches/funcs.h...

If you place a bounty on this I would be happy to pick this up 🙂

Seems like an issue with that macos ffmpeg package. vpdq uses `libavdevice`, but it doesn't use video encoding APIs or anything that `librav1e` provides, so I don't think this is...