Ian Thomas

Results 96 comments of Ian Thomas

@naavis If you look at the contents of `agg` when you are using your zero weights you will see that it contains two values, `0` and `np.nan`. Zeros correspond to...

Most these warnings have been fixed as part of #92. One remains: https://github.com/holoviz/spatialpandas/blob/518b4f1a98dc3dc2577dac31ebceb111ab017318/spatialpandas/geometry/basefixed.py#L111 We cannot force a `dtype=object` here, so it needs further consideration.

When you run `pytest` any extension array tests that are not included in the appropriate sequence are skipped as follows: ``` $ pytest spatialpandas/tests/test_fixedextensionarray.py::TestGeometryInterface ========================================================= test session starts ========================================================== platform...

@jbednar Maybe we hold off merging this for the moment and keep it in reserve whilst I fix the other CI problems.

Here are the results using asv 0.4.2: {"results": {"step_detect.Simple.time_failure": {"result": [null, 8.792673099932355e-08], "stats": [null, {"ci_99": [8.506566552892052e-08, 9.189114907855378e-08], "q_25": 8.53922904482327e-08, "q_75": 9.078514433935673e-08, "min": 8.506566552892052e-08, "max": 9.189114907855378e-08, "mean": 8.811884849472156e-08, "std": 2.778221072923389e-09, "repeat":...

I am in favour of this. The `pybind11` work becomes much simpler if we at least replace `setup_requires` in `setup.py` with `[build-system]` in `pyproject.toml`. I was going to talk about...

A temporary environment is used to build a wheel which is then installed into your working environment. The temporary environment doesn't seem to have access to the full project directory....

Note that this is adding a 3D version of `tripcolor` functionality. That does at need to be specified in the docs somewhere so that users of 2D `tripcolor` wanting to...

> It is on purpose not called `C` as in `tripcolor`, because there we give colors directly, not values to be mapped to colors. Look again! ```python import matplotlib.pyplot as...

In the long run, when all the C/C++ extensions are wrapped using `pybind11` we won't need any `numpy` in the `[build-system] requires` section. To make headway here I think it...