Ian O'Connell

Results 60 comments of Ian O'Connell

At some point i will, have a lot on this week and @sholokhov has a workaround that sounds like it'll survive for another few days anyway.

@ptarjan thats really an internal stripe discussion, but i don't believe generally speaking we'd want our main repos pointing to forks on the internet.

This issue isn't related to the other protobuf one I believe -- the last change on the protobuf thing removed the call to copy. So all of that code is...

As a user of these rules, invoking go and trying to fetch/require go externally i'd be hugely -1 on. This brings in a whole other set of dependencies/odd behaviors we...

@gravypod would the approach i did in https://github.com/bazelbuild/rules_docker/pull/2086 work for you? github actions can on demand build up the binaries. GIthub have windows runners so it can be extended to...

Which tools do you mean @alexeagle ? This PR or mine ? I guess do you mean something to handle distribution or supply of binaries. Or an off the shelf...

@pcj sorry your right -- though building in the repository rules means really confusing errors on failures, and bazel can't cache this compile right? -- any reason your against just...

- Could you speak to why it is large? the pattern that is in the repo now would support it easily no? Just means adding a few current binaries to...

@sluongng Thats great context thank you, I hadn't realized the go rules do this inside themselves. I would still have reservations that they are the location controlling the rules(+ go...

We don't have them internally, the use cases that were coming up are: https://github.com/bazelbuild/rules_scala/issues/765 https://github.com/bazelbuild/rules_scala/issues/753 https://github.com/bazelbuild/rules_scala/issues/751 so if your work managed to cover these and we didn't need it at...