Ian Lopshire

Results 9 comments of Ian Lopshire

What if a nullable struct was generated for each type. The nullable struct would conditionally be used if a field is nullable or optional. Something like: ``` type Foo struct...

@droyo I've been able to use the `omitempty-structs` branch on a number of complex schemas with out any issues. The xsd and wsdl files for the services I'v been working...

I believe this would be a good feature to add. My only concern is making sure the behavior is well documented.

I can't think of any situation where the current `Divider` interface is preferable to one that returns `[]string`. My preference would be: ```go type Divider interface { Divide(original string) (result...

I would also consider renaming `Divider` and `Joiner` to `Expander` and `Reducer` respectively. ```go type Expander interface { Expand(original string) (result []string) } type Reducer interface { Reduce(parts ...string) (result...

@lanzafame The `Coalesce` function would accept a `Validator` and return a `Reducer`. The resulting `Reducer` would return the first valid string. ```go // Coalesce creates a Reducer that returns the...

What is preventing `MarkedString[]` from being converted to `MarkupContent`? The `MarkedString` spec doesn't differentiate between `markdown` and `plaintext` so we can just default to `markdown` when converting. ```go // untested...

I wonder if this is a result of changing the pattern passed to `golint` to include `rootFSPath` (see #321). I'm also not familiar with windows pathing, but it looks like...

I think I can borrow a machine to look into this with. If I can find a solution I will submit a PR. I’ll provide an updated either way.