Ian O'Neill

Results 15 comments of Ian O'Neill

So the reason this doesn't work in the settings UI is because `Alt` + `Space` is special cased in the app's main method to delegate through to `AppHost::OnDirectKeyEvent()`, which in...

So `sendInput` is only a problem if it's called after a new terminal control is created. If you just do two `sendInput` actions one after another they work fine. The...

I don't think it will fix the problem, but making the `animating` and `shouldClear` fields of the `GifImageView` class `volatile` should reduce the chances of NPE's happening, see the java...

I never came up with a reliable test-case (I've only ever seen the crash once), but as I mentioned in my previous comment, I think marking the `animating` and `shouldClear`...

Unfortunately I never got around to trying it out.

I have written some commandline parsing tests, but didn't push them as TAEF is erroring out for some reason when running the `localTerminalApp` test suite: ``` Summary of Errors Outside...

What you are suggesting certainly sounds more powerful. Especially if you allow it to change the location of an existing window. You could _potentially_ open yourself up to malicious programs...

@DHowett it's been a couple of weeks since I opened this - have you/the team had any thoughts on what you'd like the command line args to be?

I've updated the cmdline args as per your suggestions.

We're now in the slightly weird situation where this is documented, but not merged! https://learn.microsoft.com/en-us/windows/terminal/command-line-arguments?tabs=windows