Ian Dees
Ian Dees
> I gave it an attempt at refactoring: [iandees/[email protected]:openstreetmap-website:highlight-tag-changes-in-history](https://github.com/iandees/openstreetmap-website/compare/highlight-tag-changes-in-history...pablobm:openstreetmap-website:highlight-tag-changes-in-history) History is clean and you can read each commit separately. Thoughts? That does look significantly better, thanks for taking the time...
Ok, I think the code is probably in a decent spot now. I'm going to fiddle with trying to improve the visualization a bit now.
I added +/- for value changes. It's getting a little tight in there, especially when the value is a long string like a URL. It think it helps with vision...
> But why adding the +- to the value cell? See conversation above. We are looking for something to show the change without relying solely on color.
That looks better, but it's harder to distinguish between a tag's value changing and a tag getting added. Maybe I'll change it so the key stays yellow but the value...
I've spent the evening stretching the limits of my CSS knowledge and getting fairly close to what I'm going for: I'm not happy with this yet. 1. The +/- indicators...
I switched to using an extra `` for the +/- indicators and that got it to look the way I wanted: Happy to take feedback on this before spending much...
Yep, the status of the PR is that the visual representation of tag history looks the same as the screenshot in [this comment](https://github.com/openstreetmap/openstreetmap-website/pull/6448#issuecomment-3443928967). The work that happened since is to...
> On production, keys have a grey background and values a white background. On this PR it's an all-white background. (I'm not too bothered by this one, but I don't...
Do you see specific stores that are in ATP that are closed? It looks like they still have stores in some states.