iancoleman

Results 28 comments of iancoleman

There are some bip44 derivations (eth on ledger, coinomi) that differ from bip44 despite having purpose set to 44, see https://github.com/iancoleman/bip39/issues/128#issuecomment-351655304 Looks like the best way to manage this is...

Please remove SafePayRecoveryTool.html or explain what it is and why it's included in this pr. Please remove duplicate file tests/spec/#tests.js#

Thanks for this. Please add a test.

This might be useful: https://iancoleman.io/explorer-cia-world-factbook/

Sorry there's no select all button. I had a look for some tools to do it but nothing came up. Might be a good feature to have, a csv version...

Some additional useful links from datasets/registry issue 201 referenced above > i'm thinking about packaging (some of the data) as tabular data packages: > > http://frictionlessdata.io/data-packages/ > http://frictionlessdata.io/guides/tabular-data-package/ > >...

I did some looking at conventions and the best I came up with ([google JSON style guide](https://stackoverflow.com/a/19287394)) recommends camelCase. Would camelCase be ok or would you specifically prefer PascalCase?

Another error to catch when parsing yearlySummary as per traceback ``` Removing outdated yearly summary: /home/user/cia_data/country_html/yearly_summaries/https%3A%2F%2Fweb.archive.org%2F__wb%2Fcalendarcaptures%3Furl%3Dhttps%253A%252F%252Fwww.cia.gov%252Flibrary%252Fpublications%252Fthe-world-factbook%252Fgeos%252Fau.html%26selected_year%3D2017 Fetching https://web.archive.org/__wb/calendarcaptures?url=https%3A%2F%2Fwww.cia.gov%2Flibrary%2Fpublications%2Fthe-world-factbook%2Fgeos%2Fau.html&selected_year=2017 Traceback (most recent call last): File "fetch.py", line 266, in getPage(countryPage) File...

Agreed there are some inefficiencies and implementation-specific cruft that could be improved, but I'm on the cusp of decommissioning this tool in favour of SLIP-0039 https://github.com/satoshilabs/slips/blob/master/slip-0039.md

Yes I think the feature set is still open for discussion but it feels that no matter which way the various feature combinations go some people will be left unsatisfied...