Ian Costanzo

The verifier doesn't necessarily know whether the holder will present a revocable credential or not. Or, as @swcurran describes, different issuers may issue based on the same schema, but some...

I know this is still WIP, but we need to have a description on the PR (is necessary in case anyone needs to look back on this PR in the...

Also just noticed the commit is missing the DCO signoff

> There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names....

I'm not sure off the top of my head but there's a yaml example in the demo folder: https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/demo-args.yaml I did a quick google and found this (we use the...

This line is incorrect: https://github.com/hyperledger/aries-cloudagent-python/pull/2967/files#diff-f7d9c8d89f2442a02ac7a5924be4046e195d411791e4cbfd0fd9e7e2ecb987adL557 `if cred["proof"][0].get("rev_reg_id"):` You can fetch these attributes from the credential, see for example: https://github.com/ianco/aries-cloudagent-python/commit/1903eb6d45000ff57b65a2470bcf747adc8e5a39 (Not the most elegant approach but you can use it as...

FYI the SonarCloud errors (if you don't have access to the details) are: ``` Failed conditions [42.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=hyperledger_aries-cloudagent-python&pullRequest=2967&metric=new_coverage&view=list) (required ≥ 80%) [24.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=hyperledger_aries-cloudagent-python&pullRequest=2967&metric=new_duplicated_lines_density&view=list) (required...

@EmadAnwer the coverage test is still failing on the `VCDICredFormatHandler` class (in `formats/vc_di/handler.py`). There are a couple of unit tests already that are marked as "skipped" (since they were added...

@EmadAnwer it looks like the most recent commit (removing the dup code) is missing the DCO signoff

@jamshale I've merged the PR, I'll look at updating the tags on the integration tests later ...