Ian Costanzo
Ian Costanzo
@jamshale there are conflicts, I think because I merged the other PR - https://github.com/hyperledger/aries-cloudagent-python/pull/2861
> Also added a small response payload to the upgrade endpoint. Looks good! ``` { "success": true, "message": "Upgrade to anoncreds has been triggered for wallet alice1" } ```
Some success! I was able to upgrade both of the alice and faber wallets according to my test scenario above (start alice and faber with askar wallet and in multitenant...
> ... but looks like that might not be the case. I don't think it's related to the upgrade at all, as I can replicate it with fresh anoncreds agents....
@etschelp the build for this PR is failing with a license check, however it look like I've included the license header in each of these files, any suggestions? ``` [INFO]...
> @ianco simply run `mvn license:format` once and then push the changes. Awesome thanks for the tip!
> I think the goal is to have the tests work across implementations (DIDs ledger and VC models), so there is not a need for an `@Indy` tag. ... but...
I recommend making the change in aca-py, so we can ensure the behaviour is consistent across the underlying sdk's. (Also it is a challenge to release a new indy-sdk version.)
> and the verifier does NOT specify a revocation interval. If a holder has a revocable credential that it uses in the presentation, should it include an NRP? In this...
> and some issuers provide revocable and others non-revocable credentials. You will accept any credential, but if they are revocable, you want the NRP to be included. Currently, if you...