Ian Atol
Ian Atol
Re: partial reverting of #44512: [`choltype`](https://github.com/JuliaLang/julia/blob/master/stdlib/LinearAlgebra/src/cholesky.jl#L181) from `LinearAlgebra` was causing BoundsErrors during test suite runs. Looking further, it appeared that in the following IR, ```julia Expr(:call, Main.eltype, Core.Argument(n=2)), Expr(:call, Main.oneunit,...
@nanosoldier `runtests(ALL, vs = ":master")`
@nanosoldier `runtests(["AlgebraicPetri", "AlphaStableDistributions", "Earth2014", "Evolutionary", "FameSVD", "FlashWeave", "FractionalSystems", "GeoDatasets", "GeometricFlux", "Glimmer", "GraphSignals", "GridapEmbedded", "GridapGmsh", "Hecke", "Infernal", "InformationGeometry", "IntensityScans", "JSONLines", "JetPack", "Kahuna", "LoggingExtras", "MatrixMarket", "Metida", "MultiScaleTreeGraph", "NeuralArithmetic", "NeuralOperators", "ODEInterface", "ODEInterfaceDiffEq", "OptimKit",...
`GeometricFlux`, `GraphSignals`, `GridapEmbedded`, `GridapGmsh`, `JetPack`, `NeuralOperators`, `Org`, ` PDENLPModels`, and `ValueShapes` are all caused by the same issue with FillArrays where we end up with `compute_sparams` on `Tuple{Type{FillArrays.Fill{T, N, Axes}...
@nanosoldier `runtests(["Evolutionary", "GeometricFlux", "GraphSignals", "GridapEmbedded", "GridapGmsh", "Hecke", "InformationGeometry", "JetPack", "Metida", "NeuralOperators", "ODEInterface", "ODEInterfaceDiffEq", "Org", "PDENLPModels", "ValueShapes"], vs = ":master")`
@nanosoldier `runtests(["Hecke", "Metida", "ODEInterface", "Org"], vs = ":master")`
@aviatesk Could I ask for your review here? Specifically on [3a6b36c](https://github.com/JuliaLang/julia/pull/45062/commits/3a6b36c062c36c3250ee299cf7a3ef6672262782) where I revert some of #44512, as well as on [884e5ea](https://github.com/JuliaLang/julia/pull/45062/commits/884e5eaea0443f216b26bfe426b3a4121edca5a5), where I somewhat broadly restrict the cases in...
Re: test failures in `Metida` and `ODEInterface`: The `ccall` and `cfunction`s showing up in the test aren't having their types properly calculated during inlining since we are entering `ssa_substitute_op!` while...
Seems to be passing CI as well as locally passing previously problematic package tests (`Metida`, `Hecke`, etc). I'd still like to do better on [4934be](https://github.com/JuliaLang/julia/pull/45062/commits/4934be9eb87829ea6d3cdae1ad1b5a952b820bbc)'s implementation, as well as add...
@nanosoldier `runtests(["Alicorn", "AlphaStableDistributions", "AprilTags", "AstroChemistry", "DistributedArrays", "EBayes", "EnsembleKalmanProcesses", "Evolutionary", "GadgetIO", "GasChromatographySimulator", "Hashpipe", "HetaSimulator", "ITensorTDVP", "JumpProcesses", "LibExpat", "ManifoldDiffEq", "NumericalAlgorithms", "OpenTelemetryProto", "OptimKit", "OptimizationMetaheuristics", "Oscar", "Reproject", "Retriever", "SimplexGridFactory", "SymbolicUtils"], vs = ":master")`