Ian Bennett

I tried this with a second test scenario to try to replicate the issue/narrow down exactly what's causing it. I ran a test scenario, checked all the crew actions, and...

@Dosendusche @LebombJames After some further digging I think I understand a bit better what's happening. I was getting thrown off because some of the values weren't adding up, but I...

This should also resolve https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/issues/144, ideally

Alright I think this is ready for review. Everything is working, looks nice, and the migration script should hopefully not explode anything. For now I've added a check in migration.js...

This is now fixed up and requested changes have been made. Should be ready for review. Note that I've turned migration off for now, but when weapon properties get updated...

~~Before tech/magic/hybrid items are entered, this issue (https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/issues/1220) needs to be resolved, which means PR https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/pull/1108 should be merged first.~~ This has been completed

Links to the relevant in progress PRs: - https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/pull/1273 - https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/pull/1274 - https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/pull/1276 - https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/pull/1277 - https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/pull/1279

I imagine the implementation of this would similarly resolve https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/issues/661

Turns out this is a duplicate of https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/issues/416

I've also confirmed that this doesn't cause any issues with timed effects or the compendium art mapping.