iamdanfox

Results 162 comments of iamdanfox

@nmiyake my concerns here are: 1. internally we do not recommend gitflow for a few reasons: - its long lived master & develop branches do not promote a world in...

If we're gonna implement both in this repo, my preference for a separate plugin is: - it's easier to run automation internally to just grep all repos for `com.palantir.gitflow-version` and...

Ah sorry you're absolutely right, `gitHashFull` would always be the same! Have updated the snippet above. My ulterior motive here is that I also don't like that `prefix` configurability (only...

@abless I've published https://hub.docker.com/r/iamdanfox/oldgit/ which has git 1.7.1 built from source - we should be able to use this to run a few tests :)

Fully agree! We've been using both remote and local gradle build caches internally and it's massively sped things up. Would want to make sure we have a nice accompanying test...

Would like to keep this open until this runs the standardized test-cases.yml from conjure-verification

Looking into solving this once and for all... we are already running the conjure-verification test harness (added in https://github.com/palantir/conjure-java-runtime/pull/853), but only for JaxRsClients. Next steps are: - rework [VerificationClients](https://github.com/palantir/conjure-java-runtime/blob/develop/conjure-java-client-verifier/src/test/java/com/palantir/verification/VerificationClients.java) so...

Turns out I didn't fully turn off stalebot last time!

@tpetracca this has the unfortunate side-effect of adding that retrofit dependency into _every single configuration_ in your repo. This then causes gradle-conjure to trip over with: ``` Could not determine...