Aaron Cook

Results 49 issues of Aaron Cook

Note: we intend to modify this implementation to flag imitation transfers instead of filtering them out so that the clients can display them as they see fit. ## Summary This...

We currently have a layer of abstration for data source errors. We should remove this and instead map errors to domain-specific ones, e.g. "non-existent Safe address" to improve errors and...

We should ensure addresses are checksummed for consistency and eventual comparison on the route level (as done [on the Transaction Servce](https://github.com/safe-global/safe-transaction-service/blob/913abe38f3b46d1391334c497848b48655b56897/safe_transaction_service/history/tests/test_views.py#L1204-L1207)). We should also coerce those from datasources.

The web is currently using RPC calls to retrieve recovery proposals. This is both costly and inefficient, with some chains not supporting the implementation. We should investigate the options available...

### Feature request With the implementation of "[native WalletConnect](https://github.com/safe-global/safe-wallet-web/pull/2535)", the details of the connected DApp (name, icon, etc.) are available and could be sent as part of the transaction `origin`....

**Is your feature request related to a problem? Please describe.** Changing the threshold when adding/removing an owner does not have a clear method name (e.g. `addOwnerWithThreshold`). Adding an explicit threshold...

**Describe the bug** The following endpoints only return `TRANSACTION` elements: - /v1/chains/{chainId}/safes/{address}/incoming-transfers/ - /v1/chains/{chainId}/safes/{address}/module-transactions/ - /v1/chains/{chainId}/safes/{address}/multisig-transactions/ As they are all 'historical' transactions, they should match that of the `/v1/chains/{chainId}/safes/{safe_address}/transactions/history` endpoint...

### Description When mapping ERC-20/721 transfers, we extract the values of the `sender`, `recipient`, etc. from the `decodedData` of a given transaction. Each transaction that transfers tokens also has a...

## Summary The mock data of the imitation transaction tests was taken from on-chain and was therefore not dynamic. This migrates to using builder-based mock data in order to increase...

The output of [`build_airdrop_init_tx`](https://github.com/safe-global/safe-token/blob/873141c47200e1d55e5636bd5b561479891ce767/src/tasks/airdrop.ts#L62) does not match that of the [`claiming-app-data`](https://github.com/safe-global/claiming-app-data). It should be the same.