safe-client-gateway icon indicating copy to clipboard operation
safe-client-gateway copied to clipboard

Filter endpoints not returning `DATE_LABEL`s

Open iamacook opened this issue 2 years ago • 1 comments

Describe the bug The following endpoints only return TRANSACTION elements:

  • /v1/chains/{chainId}/safes/{address}/incoming-transfers/
  • /v1/chains/{chainId}/safes/{address}/module-transactions/
  • /v1/chains/{chainId}/safes/{address}/multisig-transactions/

As they are all 'historical' transactions, they should match that of the /v1/chains/{chainId}/safes/{safe_address}/transactions/history endpoint and return DATE_LABELs nested between differing days (relevant to the timezone_offset, see https://github.com/safe-global/safe-client-gateway-nest/issues/660.

To Reproduce Steps to reproduce the behavior:

  • Call each of the endpoints with a filter query and observe that no DATE_LABEL elements are present.

Expected behavior

  • A list of TRANSACTION elements matching that of the desired filter with DATE_LABEL elements between those on different days (relevant to the provided timezone_offset). (Example client side implementation (that was removed) can be found here)

Environment (please complete the following information):

  • Staging and production
  • All chains

iamacook avatar Sep 20 '22 10:09 iamacook

After aligning internally, we will tackle this issue in https://github.com/5afe/safe-client-gateway-nest

fmrsabino avatar Sep 29 '22 09:09 fmrsabino