Iain Connor

Results 10 comments of Iain Connor

@tom91136 Doesn't appear to be working. I believe you should be calling [Activity.getIntent().removeExtra()](http://developer.android.com/reference/android/content/Intent.html#removeExtra%28java.lang.String%29) as opposed to Activity.getIntent().getExtras().removeExtra(), as the latter [creates a new copy of the extras each time](https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/core/java/android/content/Intent.java#5759). However,...

Would it be more reliable to just swap the order things are restored in? https://github.com/tom91136/Akatsuki/pull/17

Thanks for the reply. Very exciting to hear about the rewrite. I think this library has huge promise in terms of what it is attempting to solve and the performance-first...

How would @arg entries get in? Would they still be (whether they're individual or part of a bundle) part of the intent? The only thing I'm still slightly concerned with...

No, I think you're 100% right about everything there (including how messy the implementation is :angry: ), my only thought was to consider whether you're planning on abusing an "undocumented"...

Just spotted https://github.com/workarounds/bundler which seems to have a very similar scope. Their "solution" to this problem is what we were discussing earlier... letting the restoration happen twice, which, yes, is...

You can grab it from https://jitpack.io/#iainconnor/discreet-app-rate if you want to use it.

An excellent point. This should at very least be changed to an LRU cache with a size constraint. On Mon, Jan 11, 2016 at 1:26 PM, cagnulein [email protected] wrote: >...

Added some information on `SoftCachedObject` over here -- https://github.com/iainconnor/ObjectCache/pull/5#issuecomment-48966379 -- let me know if that helps it make more sense. Could possibly be solved nicer by having a unique callback...

The purpose of `SoftCachedObject` is to signify to the "client" that they are getting back the object, but it's expired so this is their last chance to refresh it. I...