Igor Afanasyev

Results 72 comments of Igor Afanasyev

It would be nice to provide more details with the bug report: what the code looked like before the paste, what was the position of the caret, what was the...

1. What happens if you search by `"dummy"` (with quotes) in Evernote Web on your sandbox account? 2. What happens if you search by `dummy` (without quotes) in Evernote Web...

Thanks, @augbog! I'll review this and add some tests a bit later. This PR doesn't block anything on your side, does it?

Yes, these are different cases. The first one is when you have missing (empty) placeholder values. The second one is an empty string as returned from Plurr formatting function. In...

Note that we don't want a _server-side-based_ consistency. Numbers are formatted according to user current locale settings, and that's the desired behavior. We only need to display numbers consistently _for...

> Otherwise, the OS locale will always be used While this is exactly the behavior I'd ideally like to get, it turns out using `.toLocaleString()` without parameters might default to...

I don't think people switch browsers often, so the end result is not that bad — it is still consistent within a browser and more readable than with no formatting...

> Also worth considering: https://styled-components.com/ I'm ok with styled components as well. Let's pick something (e.g. styled components) and try to build some of the new components with it. Then...

Can you please elaborate on the installation method and OS? For me, following the [installation instructions](https://serge.io/download/) doesn't produce any errors.