David Mitchell

Results 125 comments of David Mitchell

On Thu, May 09, 2024 at 08:10:55AM -0700, Paul Evans wrote: > This doesn't feel like it's actually a release blocker as such. > > I think it would be...

Two general comments. First, AFAIKT, nowhere do you state _what_ actual "common accessor method pattern"(s) it overrides. Second, You have a couple of non-trivial C functions with no code comments...

Some further observations: 1. Since part of this commit is to provide a new facility to effectively add a "lightweight XS" function to a CV that is allowed to bail...

On Fri, Jan 12, 2024 at 10:06:25AM -0800, Jon Gentle wrote: > > 3. The SV stored in CvSUBOVERRIDEAUX(cv) doesn't appear to be freed when the CV is freed. >...

Variable::Magic has tests which assume certain ops are present. I've submitted a ticket with a fix: https://rt.cpan.org/Public/Bug/Display.html?id=151104

On Mon, Feb 26, 2024 at 01:09:57PM -0800, andk wrote: > Also affected by the same commit: KARASIK/DBIx-Perlish-1.07.tar.gz > Sample fail report: http://www.cpantesters.org/cpan/report/72170200-d41e-11ee-8b20-fd5b2320d34f > @dk please take note That appears...

On Tue, Feb 27, 2024 at 04:07:13AM -0800, iabyn wrote: > I propose reverting this commit for now and readdress the issue after > 5.40. it's just a minor optimisation...

Now that 5.40.0 has been released, I've unreverted this commit with v5.41.0-51-g9a224d076a

On Thu, Jun 20, 2024 at 03:49:12PM -0700, James E Keenan wrote: > I built a perl at a commit later than the one at which @iabyn committed > yesterday....

Should be fixed in blead now by v5.39.8-73-g0476589cca