David Mitchell
David Mitchell
On Wed, Oct 08, 2025 at 04:53:18PM -0700, Leon Timmermans wrote: > Should we still use PREINIT? I see it's use-case in C89, but in C99 it > can be...
On Sat, Oct 11, 2025 at 03:00:31PM -0700, Leon Timmermans wrote: > @Leont commented on this pull request. > > > > > + require XSLoader; > + XSLoader::load(__PACKAGE__, $VERSION);...
On Thu, Oct 16, 2025 at 05:44:45PM -0700, Matthew Horsfall (alh) wrote: > @wolfsage commented on this pull request. > Is this intended to be a link to other documentation?...
On Mon, Oct 20, 2025 at 07:58:13PM -0700, Tony Cook wrote: > > +=head3 Perl OPs ... > 99%* of XS code doesn't touch OPs, I don't think it needs...
On Mon, Oct 20, 2025 at 08:35:05PM -0700, Tony Cook wrote: > I'm not sure it's good to go into so much detail on the internal > structure of SVs...
On Sun, Oct 26, 2025 at 05:34:58PM -0700, Tony Cook wrote: > + This SV has a lifetime which is the same as the sub which the OP is >...
Thanks for all the feedback so far. The two commits I've just appended / pushed to this branch contain fixups for every comment from your reviews. As a general rule,...
Does anyone still intend to do any further review? Or is this PR approaching being mergeable?
I will merge this PR within a few days unless anyone has any last-minute objections.
I've just rebased the PR and added one additional commit which addresses the nits raised in the last week.