Julien Cretin

https://github.com/rust-embedded/riscv/pull/254#issuecomment-2591208986 > Let's leave this PR and #247 open to keep discussing what to do with weak symbols. Has there been progress regarding the fate of other weak symbols? Or...

> I'm not sure how default features work when one dependent crate uses `no-default-features` but other dependent crate does not explicitly disable default features. If a crate depends on a...

I also believe we shouldn't rely on default features because they only make sense for additive features. And I also believe they are a misfeature. They should only be enabled...

> No, it's subtractive because it literally conditionally excludes code from the library. It "subtracts" the `abort` routine, and other code from the library. That's also not what "additive feature"...

> Maybe you can try this: [#200 (comment)](https://github.com/rust-embedded/riscv/pull/200#discussion_r1601316656) and see if it resolves it. It should discard asm syms in LTO consideration. I tried it and it fixes the issue,...

> Huh, I tried almost exactly that and it didn't fix the issue. Wonder what I did differently. Turns out it doesn't always work, so it's not a very reliable...

Thanks for the request! This base32 variant is an interesting one. It makes very little sense to me to design such a thing and I'm curious of the decisions that...

If the problem is that tests run in parallel, we could either use `cargo test --features=std -- --test-threads=1` but this is going to slow everything down. Or we could try...

> Is OpenSK aiming for any targets without atomics? OpenTitan (for example) doesn’t have atomics but I couldn’t think of an alternative solution. It is sometimes possible to use `portable-atomic`...

If the intent of this check is to make sure the library doesn't do parallel hashes, then we shouldn't disable it in tests. We sadly need to use `--test-threads=1` or...