Julien Cretin
Julien Cretin
Actually, I would argue that having this `publish` field (defaults to `true` for backward compatibility) is useful even for originally explicit build-targets (not just implicit built-targets that must be made...
The actual requirement seems to be glibc >= 2.35 (ubuntu 22.04), see https://github.com/pykeio/ort/pull/293.
> Can we link against an old version of ort crate so that we don't need such a high version of glibc? That could be an option, but that would...
The difference is probably that you need to add the `download-binaries` feature of `ort`. Since compiling ONNX Runtime from source is the proper solution. So the problem is not the...
I don't know, it just needs to be done, and confirm that there are no other problems on that new step.
Ok so I probably have something working (still need to wait some confirmation/cleanup workflow runs). Apparently, the v2 of `ort` expects ONNX Runtime 1.19.2. Using 1.18 or older will result...
I'm not sure how well we'll be able to integrate with the existing workflow. The 2 difficult points are: - We need to use a cache because building ONNX Runtime...
In this workflow, you can get all the wheels generated by Maturin: https://github.com/google/magika/actions/runs/11437454207. (Note that the cache reduces the runtime from 40 minutes to 2 minutes.)
Ah right, the `README` is because of `sdist`, let me add that to the workflow and see if I can add the same tests.
By the way, this can be considered an incremental part of the larger effort started in #1664. Commenting to create the link between both PRs since there was none yet.