Andrey Pyzhikov

Results 34 comments of Andrey Pyzhikov

I would like to ask you to change the declaration of methods according to PSR-12 (there is an example here: https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments). Because the string is longer than 120 characters.

@kenjis @MGatner What do you think if the three arguments ($field, $label, $originalField) are replaced with an array or a DTO?

@ping-yee Add a description to the changelog.

The usage example is rather ambiguous. It can be replaced with. ```php $data = [ 'title' => 'My title', 'name' => 'My Name', 'date' => '2022-01-01', ]; $builder->set([ 'id' =>...

> What do you guys think? To be honest, the ``setBatch()`` method has a very general name structure. If you look at the surface and do not refer to the...

What if this code is implemented as a trait? It does not depend on the query builder, so it can also be used, for example, on the Response class or...

> What about updateBatch()? ```php $db->table('test')->testMode()->setUpdateBatch($set)->updateBatch($data, 'value', 1); $db->table('test')->testMode()->setUpdateBatch($set)->updateBatch(null, 'value', 1); //throws // CodeIgniter\Database\Exceptions\DatabaseException : One or more rows submitted for batch updating is missing the specified index. // CodeIgniter4\system\Database\BaseBuilder.php:2121...

Situations can be different, so I think any valid behavior needs to be handled. After all, setInsertBatch() was added for something.

I think in insertBatch() one can wrap $set in setInsertBatch(); ``string $value = ''`` in setInsertBatch() ??? for what?

1. What is a OSS app? 2. Can you give a specific example? 3. If the application has changed and the changes made by the user are not saved. This...