Jacob Overgaard

Results 110 comments of Jacob Overgaard
trafficstars

Hi @bjarnef We are planning to review this very soon, and as you pointed out it would be useful in the new backoffice.

Hi @bjarnef, is there anything we can assist you with from HQ's side?

Trying to look into it, @bjarnef. It's a bit odd. Seems like it doesn't register any of the new types unless explicitly building the uui-base package. But even then it...

You can continue targeting v1/dev here. We want to use v1/contrib moving forward for external pull requests.

I figured it out, I think. There were some references to an older version of uui-base which resulted in the package being symlinked incorrectly. I allowed myself to push to...

> But clamp and math wasn't copied to this folder (I guess it failed before building/copying these). Yeah, we are using npm workspaces here so it actually symlinks the folder...

@bjarnef It works on the `dev` branch for me. I seem to remember I had to delete the node_modules folder at some point because of an update to Storybook. Have...

@bjarnef Could I persuade you to try with Node 16 and npm 8? The build on your PR is failing with even more missing packages now. The recommendation for building...

Ahh good, good. I actually ran into the same problem on your repo as you described above. I think the issue stems from npm trying to upgrade the old lockfile....

I'll update the contributing guide - thanks for the suggestion!