i1sm3ky

Results 24 comments of i1sm3ky

I found a way to check which theme is being used by using darkdetect. I wanted to ask is there a good way of checking if we are running GNOME...

> I wondered why detecting via QPalette doesn't work. Or maybe it does... It does! I'm using `self.app.paletteChanged.connect(self.set_tray_icon)` along with darkdetect to detect and change the icon for light or...

> Can you enclose relevant output including the error message? It's a normal module not found error: ``` 2023-04-01 13:37:38,971 - root - CRITICAL - Uncaught exception, file a report...

> What about https://github.com/borgbase/vorta/blob/e0fe766051e521396d7d58f973d1f8002ff749ad/src/vorta/utils.py#L374-L379 > > > > Can this be used to determine the colour of the tray icon? I guess, Yes. Let me check if this works. BTW...

> https://github.com/borgbase/vorta/blob/e0fe766051e521396d7d58f973d1f8002ff749ad/src/vorta/utils.py#L374-L379 I tried this, but it didn't worked reliably, It returns `False` even when in dark mode. For now I've implemented the white icons for GNOME and MacOS(I think...

> Which attribute of the MacOS palette is the cause of this? The `uses_dark_modes` works on the principle of checking the contrast between text colour and window colour but on...

> Did you call it after `QApplication` was initialized completely? Yes, it was called after QApplication was completely initialized.

> Interestingly, installing pyqt6 on macOS M1 just works (unlike pyqt5): PyQt6 natively supports ARM architecture, PyQt5 used to support ARM but a recent PyQt update broke the support for...

Hey @m3nu, I got most of it to work with PyQt6. But when running the tests its failing on one and giving errors on two ``` FAILED tests/test_extract.py::test_selection - AttributeError:...

Yeah sure! I'll create a PR in a bit. Edit: Also could you please check my PR for the White icons on MacOS issue? It changes the tray icon color...