iroha

iroha copied to clipboard

I feel strange that torii is used to "block" iroha. Imo it would be simpler design if iroha would always spawn `torii` in sparate task as any other service. And...

0x009922

Trigger execution order

2

Maybe this is a non-issue, but we should define what the order of execution of triggers is when multiple triggers are triggered at the end of block. Also, impose ordering...

mversic

Improve transactions submitting API in Client

1

check [here](https://github.com/hyperledger/iroha/pull/3485#discussion_r1216872211) for suggestions

mversic

`I2::Dev::Publish::sonarqube-defectdojo` [fails](https://github.com/hyperledger/iroha/actions/runs/9108611943/job/25039754515#step:5:53) due to a rate limit in `dawidd6/[email protected]`: ``` Error: API rate limit exceeded for site ID installation. If you reach out to GitHub Support for help, please include...

nxsaken

Currently serialization of trigger set is redundant because it includes ids of triggers twice: in `ids` field and in specialized trigger fields. Check if this can be removed, one concern...

Erigara

Error messages in `no_std` are useless

1

Due to usage of - `#[cfg_attr(feature = "std", derive(thiserror::Error))]` and - `#[cfg_attr(feature = "std", source)]` We lose a lof of info about errors. Because of that `Debug` print of, for...

Arjentix

Reasons to consider the switch: * It applies to the entire workspace. Some lints are enforced as a matter of policy, e.g. groups like pedantic and restriction. However, most are...

mversic

Update the contributing guide

3

Make sure that the contributing guide reflects these recent changes: - we switched to Conventional Commits in #4502 - we stopped labeling new issues and PRs with `iroha2` in #4501...

nxsaken

coverage measurement targets

2

_Originally posted by @s8sato in https://github.com/hyperledger/iroha/pull/4573#discussion_r1596320435_ Define appropriate coverage measurement targets: - Numerator: - Should coverage by `p2p/tests/integration` be considered? - Denominator: - What parts of the code do not...

s8sato

To implement #3671 we would need to add more predicate types like account predicates or asset predicates. However our current API allows the clients to specify any predicate filter, without...

DCNick3