coverage measurement targets
Originally posted by @s8sato in https://github.com/hyperledger/iroha/pull/4573#discussion_r1596320435
Define appropriate coverage measurement targets:
- Numerator:
- Should coverage by
p2p/tests/integrationbe considered?
- Should coverage by
- Denominator:
- What parts of the code do not need to be covered by tests?
Currently, our coverage is failing to ignore certain paths:
The coverage generating command expects client_cli should be ignored, while sonar (you may need to request access to DevOps) detects 753 uncovered lines in client_cli/pytests.
A weird thing is that the source of the coverage report (lcov.info as a CI artifact e.g. as seen here) does not mention client_cli except for client_cli/build.rs which has 0 uncovered lines
Solved via Sonarqube settings
Currently, our coverage is failing to ignore certain paths: The coverage generating command expects
client_clishould be ignored, while sonar (you may need to request access to DevOps) detects 753 uncovered lines inclient_cli/pytests. A weird thing is that the source of the coverage report (lcov.infoas a CI artifact e.g. as seen here) does not mentionclient_cliexcept forclient_cli/build.rswhich has 0 uncovered lines
@s8sato @BAStos525 can you close this if it's finished?