iroha icon indicating copy to clipboard operation
iroha copied to clipboard

coverage measurement targets

Open s8sato opened this issue 1 year ago • 2 comments

Originally posted by @s8sato in https://github.com/hyperledger/iroha/pull/4573#discussion_r1596320435

Define appropriate coverage measurement targets:

  • Numerator:
    • Should coverage by p2p/tests/integration be considered?
  • Denominator:
    • What parts of the code do not need to be covered by tests?

s8sato avatar May 14 '24 06:05 s8sato

Currently, our coverage is failing to ignore certain paths: The coverage generating command expects client_cli should be ignored, while sonar (you may need to request access to DevOps) detects 753 uncovered lines in client_cli/pytests. A weird thing is that the source of the coverage report (lcov.info as a CI artifact e.g. as seen here) does not mention client_cli except for client_cli/build.rs which has 0 uncovered lines

s8sato avatar Aug 19 '24 06:08 s8sato

Solved via Sonarqube settings

Currently, our coverage is failing to ignore certain paths: The coverage generating command expects client_cli should be ignored, while sonar (you may need to request access to DevOps) detects 753 uncovered lines in client_cli/pytests. A weird thing is that the source of the coverage report (lcov.info as a CI artifact e.g. as seen here) does not mention client_cli except for client_cli/build.rs which has 0 uncovered lines

BAStos525 avatar Aug 19 '24 13:08 BAStos525

@s8sato @BAStos525 can you close this if it's finished?

mversic avatar Oct 10 '24 14:10 mversic