Yunfei He

We used to throw errors for implicit external modules. And for better DX, I changed to throw warnings rather than errors, which will terminate the build. We could add a...

One case: warning doesn't force people to write correct code/config https://github.com/rolldown/rolldown/pull/1659/files#r1682246660

It's suggested that: - You could place the transform logic on multiple declarations in https://github.com/rolldown/rolldown/blob/4dc323cf46681d57d56592ee0b7ebdefdaa96268/crates/rolldown/src/utils/tweak_ast_for_scanning.rs - Create a `VariableDeclarationExt` trait in https://github.com/rolldown/rolldown/blob/4dc323cf46681d57d56592ee0b7ebdefdaa96268/crates/rolldown_oxc_utils/src/ext/mod.rs - Create a method `fn unfold_declarators(&mut self, alloc:...

I give a rough look, it's not worth to wrap `ModuleTable` in `Arc` just for support `this.getModuleInfo`. Compatibility not comes first. If we can't implement a compatible feature in reasonable...

This is due to the limitation of node-api. `napi_set_named_property` and ``napi_set_named_property` consider `\0` as terminator rather values. To solve the problem, we first use the workaround: - Convert the `String`...

> It seems we can close this issue now. https://github.com/rolldown/rolldown/blob/5dd140ed553242d9328f483942d1f4f01daed1c1/crates/rolldown/src/ecmascript/ecma_generator.rs#L51-L56 I had a quick try on removing this code, it will produces some errors.

https://github.com/rolldown/rolldown/pull/2991 fix the issue by using workaround. But the true fix should be done by napi's side. It could done by enable napi's `experimental` and `node_version_detect` feature. `node18` is the...

So let's make `WEAK: true` by default in `JsCallback` and remove the customization, since they are all `WEAK: true` now.

I looked into it. The current workaround would be use different struct for main and worker threads. Making NAPI-RS supporting generic could reduce the maintain overhead. @Brooooooklyn

let's on hold this pr before #1003.