Yunfei He
Yunfei He
> @hyf0 Can you give me test case in Rolldown so I can test the whole thing end to end? I could give one or two cases, but I don't...
> if we reduce the scope to inlining process.env.x and identifiers Yeah. This could be start for implementing expression replacement, but in the end we gonna need a general-used expression...
Tests from wepback: https://github.com/webpack/webpack/blob/4baf1c075d59babd028f8201526cb8c4acfd24a0/test/statsCases/define-plugin/webpack.config.js
Kind of curious the steps of how oxc pass the serialized ast to the js. If I understand correctly, it should be: (`oxc AST` in rust) => (serialize to json...
Panic fixtures need to either being fixed or ignored. Adding `expect_uncaught_error: true` to make the test pass and pretend everything is fine is not expected.
> Sorry I wanted to emphasize that the standard testing process for esbuild includes these panic fixtures This is already done by `expected_error` field. If some errors should be caught...
@toyobayashi Thanks. This should be a windows-specific problem. I guess we should give a sensible default value for windows.
Sorry to say that https://github.com/rolldown/rolldown/pull/975 breaks building basic-example in unbuntu. I can't figure out why with the changed code should not affect wasm.
I have something in mind to fix this. It requires to change the core code a little bit and I'm thinking how to apply the fix.
Need to wait for https://github.com/oxc-project/oxc-resolver/issues/164.